[NO-TICKET] Don't put results in benchmarking folder directly #3833
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3833 +/- ##
=======================================
Coverage 97.86% 97.87%
=======================================
Files 1264 1264
Lines 75762 75762
Branches 3720 3720
=======================================
+ Hits 74146 74151 +5
+ Misses 1616 1611 -5 ☔ View full report in Codecov by Sentry. |
**What does this PR do?** This PR tweaks the configuration for benchmark output results to place result files in the current directory the benchmark gets executed from, instead of placing the results in the benchmarks directory. **Motivation:** In #3810 we standardized the results output file name in benchmarks to match the benchmark name. In that PR, we used `__FILE__` as a prefix. This changed where results are placed: where previously they were placed in the current folder where the benchmarks were run from (often the root of the repo), with this PR, they started getting placed in the benchmarks directory. This clashes with our `validate_benchmarks_spec.rb` that look for files in those directories, e.g. running a benchmark and then running the test suite will make the test suite fail which is somewhat annoying. While I could've changed the tests to filter out results files, I also find it useful to place the results where I'm executing the benchmarks from, as it makes organization easier (you just run the benchmark from where you want and you get the result there ). **Additional Notes:** N/A **How to test the change?** Run the benchmarks and confirm the results file gets placed in the current folder! :)
ivoanjo
force-pushed
the
ivoanjo/dont-put-results-in-benchmark-folder
branch
from
b971c15
to
5a52a42
Compare
marcotc
approved these changes
Aug 9, 2024
|
I need to tweak our test execution harness before merging this, it's failing with |
|
This is currently blocked by https://github.com/DataDog/benchmarking-platform/pull/92 |
ddyurchenko
approved these changes
Aug 12, 2024
BenchmarksBenchmark execution time: 2024-08-12 13:47:20 Comparing candidate commit 5a52a42 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 2 unstable metrics. scenario:profiler gc
scenario:stack collector
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tweaks the configuration for benchmark output results to place result files in the current directory the benchmark gets executed from, instead of placing the results in the benchmarks directory.
Motivation:
In #3810 we standardized the results output file name in benchmarks to match the benchmark name.
In that PR, we used
__FILE__as a prefix. This changed where results are placed: where previously they were placed in the current folder where the benchmarks were run from (often the root of the repo), with this PR, they started getting placed in the benchmarks directory.This clashes with our
validate_benchmarks_spec.rbthat look for files in those directories, e.g. running a benchmark and then running the test suite will make the test suite fail which is somewhat annoying.While I could've changed the tests to filter out results files, I also find it useful to place the results where I'm executing the benchmarks from, as it makes organization easier (you just run the benchmark from where you want and you get the result there ).
Additional Notes:
N/A
How to test the change?
Run the benchmarks and confirm the results file gets placed in the current folder! :)